add pound-force inch torque conversion #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+47
to
+50
| ConversionNode( | ||
| coefficientProduct: 0.1129848290854088, | ||
| name: TORQUE.poundForceInch, | ||
| ), |
There was a problem hiding this comment.
I suggest to implement it as 1/12 of pound force feet
There was a problem hiding this comment.
to be honest I am not familiar with the laguage, do you have a suggestion on how to reference the value or should I just write 1.35581794902490555/12
There was a problem hiding this comment.
Add the ConversionNode as a List to the leafNode property of the pound force feet conversionNode
|
There seems to be also format issues. Could you please run |
|
Closing this for now since for lack of activity in the past year. Feel free to reopen it or just ping me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this would be a first step towards ferraridamiano/ConverterNOW#251